Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay call to setVisitorIdCookie to prevent cookie creation when cookies disabled #17942

Closed

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Fixes #17892

Review

@justinvelluppillai justinvelluppillai added this to the 4.5.0 milestone Aug 31, 2021
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 31, 2021
@justinvelluppillai
Copy link
Contributor Author

build js

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 15, 2021
@justinvelluppillai justinvelluppillai removed the Stale The label used by the Close Stale Issues action label Sep 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 1, 2021
@justinvelluppillai justinvelluppillai modified the milestones: 4.5.0, 4.6.0 Oct 7, 2021
@justinvelluppillai
Copy link
Contributor Author

build js

@justinvelluppillai
Copy link
Contributor Author

Recreating to fix submodule issues

@justinvelluppillai justinvelluppillai deleted the 17892-cookies-created-when-disabled branch February 17, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't create test cookies when cookies are disabled
1 participant