Load sparkline images only once they are near view port #17937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix #17774
Test locally and worked nicely. Had 11 goals and on my screen it loaded the first 9 goals right away and the other ones while scrolling. This way, if someone has say 25 goals, then we won't issue like 80 requests at the same time on goals overview or funnels overview page which can cause issues in the web server as well as database.
This won't impact reports like Visitors overview etc. where the sparklines are visible right away.
Works in modern browsers.
FYI @mattab
Review