@justinvelluppillai opened this Pull Request on August 30th 2021 Contributor

Description:

Provides some compatibility for PHP8.1.

See #17686

Review

@tsteur commented on September 3rd 2021 Member

@justinvelluppillai there's now a screenshot test failing eg https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/48388/Installation_system_check.png which is maybe not expected? Eg it is showing now 0 and it looks like someone configured 0 when nothing is configured

@justinvelluppillai commented on September 3rd 2021 Contributor

Thanks - fixed now. It was actually the other way around, my change was stripping values that were previously shown.

This Pull Request was closed on September 3rd 2021
Powered by GitHub Issue Mirror