Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple fixes for PHP8.1 #17929

Merged
merged 2 commits into from Sep 3, 2021
Merged

Simple fixes for PHP8.1 #17929

merged 2 commits into from Sep 3, 2021

Conversation

justinvelluppillai
Copy link
Contributor

@justinvelluppillai justinvelluppillai commented Aug 30, 2021 •
edited

Description:

Provides some compatibility for PHP8.1.

See #17686

Review

@justinvelluppillai justinvelluppillai added this to the 4.5.0 milestone Aug 30, 2021
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 30, 2021
@justinvelluppillai justinvelluppillai mentioned this pull request Aug 30, 2021
Closed
38 tasks
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Aug 30, 2021
@justinvelluppillai justinvelluppillai marked this pull request as ready for review August 30, 2021 05:18
@justinvelluppillai justinvelluppillai removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 30, 2021
@tsteur
Copy link
Member

tsteur commented Sep 3, 2021

@justinvelluppillai there's now a screenshot test failing eg https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/48388/Installation_system_check.png which is maybe not expected? Eg it is showing now 0 and it looks like someone configured 0 when nothing is configured

@justinvelluppillai
Copy link
Contributor Author

Thanks - fixed now. It was actually the other way around, my change was stripping values that were previously shown.

@tsteur tsteur merged commit 0914642 into 4.x-dev Sep 3, 2021
@tsteur tsteur deleted the 17686-php-81-compatibility branch September 3, 2021 02:12
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinvelluppillai @tsteur