Improve check for correctly set cookie by casting to string #17928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvelluppillai
added
not-in-changelog
|
build js |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
sgiehl
approved these changes
Sep 6, 2021
sgiehl
pushed a commit
that referenced
this pull request
Sep 7, 2021
* Improve check for correctly set cookie by casting to string * rebuilt piwik.js Co-authored-by: justinvelluppillai <justinvelluppillai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #17926
Cookies are string values so if we set a cookie with an int value we need to check the string value of that int against the set cookie to make sure it was correctly set (otherwise eg '12345' !== 12345 and we log an unnecessary console error)
Review