Improves Overlay UI tests #17920
Merged
Improves Overlay UI tests #17920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
sgiehl
force-pushed
the
overlayuitests
branch
7 times, most recently
from
0f74831
to
e4dc72a
Compare
sgiehl
force-pushed
the
overlayuitests
branch
from
e4dc72a
to
2d77201
Compare
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
sgiehl
force-pushed
the
overlayuitests
branch
from
2d77201
to
c675109
Compare
sgiehl
force-pushed
the
overlayuitests
branch
from
c675109
to
2eee81b
Compare
|
@tsteur could you have a quick look at this one. It actually only adds some more tests for the Overlay to avoid future regressions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With #17851 we had fixed a couple of overlay issues that actually were not discover by tests. To avoid regressions in the future, I've added / improved the Overlay UI tests to test some more test scenarios.
Review