If a usable archive exists and the invalidation is for a specific plugin, delete the invalidation #17918

Description:

Delete plugin invalidations that are ignored because a newer archive exists, otherwise invalidations get stuck there indefinitely.

Review

• [ ] Functional review done
• [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done
• [ ] Wording review done
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

Fixes #17752

The code looks good. A test for this could be added to QueueConsumerTest (or an existing test modified).

Most of those tests work the same way, they:

1. setup the QueueConsumer instance
2. insert some archive_invalidations entries
3. then select everything through the QueueConsumer instance, collecting the invalidations in an array
4. and check that the result of that array equals a hardcoded expected value

You could add some invalidations to an existing test (ie, add a plugin invalidation for date/period, then add a recent archive 'done' row so it thinks there's a usable archive (note Date::$now can be set to make it seem recent), and check that it is both not selected and deleted afterwards). You can also do this in a new test by copy-pasting test_invalidateConsumeOrder() and changing $invalidations and $expectedInvalidationsFound, and adding the extra archive row insertion.

Sorry, github notifications said my review was requested, but i think that might have been the original request.