Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intl cldr 39 #17917

Merged
merged 4 commits into from Aug 26, 2021
Merged

Update intl cldr 39 #17917

merged 4 commits into from Aug 26, 2021

Conversation

Findus23
Copy link
Member

followup to #15607

While looking into the translations, I noticed that this hasn't been updated in a while and the URLs were pointing to the old archived repositories.
I also updated the URLs to not point to the master branch (containing beta versions), but at a stable release.

I replaced VEF with VES (see https://en.wikipedia.org/wiki/Venezuelan_bol%C3%ADvar)

Lastly I ran the script once with the latest 39 release and checking the English, German and French strings the changes are quite minor.

Review

@Findus23 Findus23 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: i18n For issues around internationalisation and localisation. labels Aug 24, 2021
@Findus23
Copy link
Member Author

Findus23 commented Aug 24, 2021

The largest change I noticed while scrolling through the files (as far as I can see without understanding most languages) is that Spanish now doesn't have any dots anymore after short day/week/etc. names (so lun instead of lun.)

Also a large fraction of the Georgian file has changed as words like აზია have been replaced with Აზია with the first letter now being a GEORGIAN MTAVRULI CAPITAL LETTER AN. Mtavruli seems to be a concept similar to uppercasing, is used in titles and a rather recent addtion to unicode 11 in 2018.

@tsteur
Copy link
Member

tsteur commented Aug 24, 2021

@Findus23 @sgiehl do we have a command to generate this? Should this be executed periodically say every 6 months? If that's the case be great to know then we can document this internally and create a process for it.

@Findus23
Copy link
Member Author

@tsteur Apart from the first two commits this is just a run of php console translations:generate-intl-data (and the next time updating $CLDRVersion)

@tsteur
Copy link
Member

tsteur commented Aug 24, 2021

how often should this happen?

@Findus23
Copy link
Member Author

Findus23 commented Aug 24, 2021

I added a short description on how to update to matomo-org/developer-documentation#523

I'd say at most this needs to be updated ever major release of CLDR (which is every few months), but in this PR we are skipping three major releases and the changes are still pretty minor.
So I'd say to do this every 1-2 years or when a country/language/currency in the world changes its name (like with North Macedonia and Eswatini in the last PR).

And when a new Language is added to Matomo, I think this also needs to be done to fetch the strings for this language.

@tsteur
Copy link
Member

tsteur commented Aug 24, 2021

Thanks I've documented this process also internally and set up a reminder every 6 months for us to look into this.

@sgiehl sgiehl added this to the 4.5.0 milestone Aug 25, 2021
@sgiehl sgiehl merged commit 13b22af into 4.x-dev Aug 26, 2021
@sgiehl sgiehl deleted the update-intl-cldr-39 branch August 26, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants