New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new config setting to set a contact email address #17916
Conversation
As the author of the mail to security@matomo.org, that lead to this PR, I just wanted to say thank you. And I hope that the build and Merge Issues can be fixed |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
8217015
to
022ae72
Compare
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
022ae72
to
ce8689e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally good. A UI test will need fixing though https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/50182/UIIntegrationTest_admin_diagnostics_configfile.png
Could you also create an FAQ for this? And where else would we mention this? Maybe in security guide?
to use instead of all super user email addresses
ce8689e
to
a2aeb78
Compare
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
@sgiehl if tests pass this should be good to merge |
Description:
There are currently a few places where a user is suggested to contact the administrator of the Matomo instance. In most cases there is a
mailto
link that contains the email addresses of all super users.In some scenarios it might be unexpected that in this places the (possibly private) mail addresses are disclosed.
To avoid this, this PR introduces as new config setting to set a contact email address, that will be used for those links instead.
By default this config setting isn't set and it falls back to use all super users emails.
In companies for example it might be more helpful to send an email to a support mailbox instead of sending an email to some specific persons.
Review