Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new config setting to set a contact email address #17916

Merged
merged 5 commits into from Oct 28, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 24, 2021

Description:

There are currently a few places where a user is suggested to contact the administrator of the Matomo instance. In most cases there is a mailto link that contains the email addresses of all super users.

In some scenarios it might be unexpected that in this places the (possibly private) mail addresses are disclosed.
To avoid this, this PR introduces as new config setting to set a contact email address, that will be used for those links instead.
By default this config setting isn't set and it falls back to use all super users emails.

In companies for example it might be more helpful to send an email to a support mailbox instead of sending an email to some specific persons.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 24, 2021
@Schwuuuuup
Copy link

As the author of the mail to security@matomo.org, that lead to this PR, I just wanted to say thank you. And I hope that the build and Merge Issues can be fixed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2021

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 4, 2021
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Sep 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 5, 2021
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 18, 2021
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally good. A UI test will need fixing though https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/50182/UIIntegrationTest_admin_diagnostics_configfile.png

Could you also create an FAQ for this? And where else would we mention this? Maybe in security guide?

plugins/CorePluginsAdmin/templates/safemode.twig Outdated Show resolved Hide resolved
plugins/Morpheus/templates/ajaxMacros.twig Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Oct 28, 2021
@tsteur
Copy link
Member

tsteur commented Oct 28, 2021

@sgiehl if tests pass this should be good to merge

@sgiehl sgiehl added this to the 4.6.0 milestone Oct 28, 2021
@sgiehl sgiehl merged commit 518fcb3 into 4.x-dev Oct 28, 2021
@sgiehl sgiehl deleted the contactaddress branch October 28, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants