Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent parameter names for trackEcommerceOrder between js API and _normal_ docs #17909

Closed
lennart opened this issue Aug 20, 2021 · 3 comments
Closed

Inconsistent parameter names for trackEcommerceOrder between js API and _normal_ docs #17909

lennart opened this issue Aug 20, 2021 · 3 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@lennart
Copy link

lennart commented Aug 20, 2021

Parameter names used in the Example of Tracking the Ecommerce Order

do not match the parameter names in the JS Tracking Client documentation

However, the example includes more detail than the API docs (E.g. expected types and default values).

It would be great if both were consistent.

I'll also file a new issue on the developer-documentation issue tracker (as the issue-template suggests)
This was referenced Aug 20, 2021
Open
Open
@tsteur
Copy link
Member

tsteur commented Aug 22, 2021

@lennart thanks for bringing this up. Do you refer to revenue vs grandTotal?

@lennart
Copy link
Author

lennart commented Aug 23, 2021

yes, also see jonkoops/matomo-tracker#563 for more of the discussion.

@tsteur
Copy link
Member

tsteur commented Aug 23, 2021

Thanks for this @lennart . I've updated the guide.

@tsteur tsteur closed this as completed Aug 23, 2021
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lennart @tsteur