Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing whitespace #17903

Closed
wants to merge 6 commits into from
Closed

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Aug 18, 2021

A few fixes noticed on weblate.
I hope those whitespace are not required for properly spacing texts on the site. But if they are, things are already broken as they are missing in all translations.

Review

@Findus23 Findus23 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: i18n For issues around internationalisation and localisation. labels Aug 18, 2021
@Findus23 Findus23 marked this pull request as draft August 18, 2021 13:00
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think the failing UI tests are unrelated?

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2021

@Findus23 Thanks for doing that. We might maybe need to wait with merging that until we migrated to weblate. If we merge that now Transifex would remove all already done translations for that. Not sure if weblate has a better handling for whitespace changes.

@Findus23
Copy link
Member Author

Indeed I would wait for a bit with merging this. I also kept it a draft so I can add more things I might notice during the weblate migration.

I don't know how weblate handles whitespace changes, but I have already seen that if a source string changes, the translators will see a diff of the string and can apply the changes to the translation.

@Findus23
Copy link
Member Author

The trailing whitespace were fixed with the Weblate migration

@Findus23 Findus23 closed this Aug 30, 2021
@Findus23 Findus23 mentioned this pull request Aug 30, 2021
11 tasks
@sgiehl sgiehl deleted the fix-translation-source-strings branch January 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants