@geekdenz
fixes #15135
Description:
Link to a helpful FAQ in the error message. This only shows when there is an error.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
Are there more places this needs to be added?
@sgiehl
I know this wasn't mentioned in the original issue, but wouldn't it makes sense to show this message only to super users? The message already says to contact the administrator if it happens again, which should be enough for normal users.
@mattab
Are there more places this needs to be added?
have you tried searching for the translation string like this: https://github.com/matomo-org/matomo/search?q=General_ErrorRequest where i can see these for example:
- https://github.com/matomo-org/matomo/blob/2b35b46a0988f8c3b6f848c59be8d7d918965a52/plugins/Morpheus/templates/ajaxMacros.twig#L20-L24
- https://github.com/matomo-org/matomo/blob/2b35b46a0988f8c3b6f848c59be8d7d918965a52/plugins/MultiSites/angularjs/dashboard/dashboard.directive.html#L61
- https://github.com/matomo-org/matomo/blob/b20dc4dc0e2c535e6a151e73a8631b1dc09d4821/plugins/Dashboard/javascripts/dashboardWidget.js#L176
Maybe we could add it there as well somehow?
I know this wasn't mentioned in the original issue, but wouldn't it makes sense to show this message only to super users? The message already says to contact the administrator if it happens again, which should be enough for normal users.
Thanks for picking this up, yes, it would be important to only show the FAQ link to Super users :+1:
Yes, I had found quite a few references myself, but thought I'd ask in the PR before committing too much effort into it.