Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show users more informative information on error #17900

Merged
merged 5 commits into from Sep 4, 2021
Merged

show users more informative information on error #17900

merged 5 commits into from Sep 4, 2021

Conversation

geekdenz
Copy link
Contributor

@geekdenz geekdenz commented Aug 18, 2021

fixes #15135

Description:

Link to a helpful FAQ in the error message. This only shows when there is an error.

Review

@geekdenz geekdenz added the Needs Review PRs that need a code review label Aug 18, 2021
@geekdenz geekdenz added this to the 4.5.0 milestone Aug 18, 2021
@geekdenz
Copy link
Contributor Author

Are there more places this needs to be added?

@sgiehl
Copy link
Member

sgiehl commented Aug 18, 2021

I know this wasn't mentioned in the original issue, but wouldn't it makes sense to show this message only to super users? The message already says to contact the administrator if it happens again, which should be enough for normal users.

@mattab
Copy link
Member

mattab commented Aug 18, 2021

Are there more places this needs to be added?

have you tried searching for the translation string like this: https://github.com/matomo-org/matomo/search?q=General_ErrorRequest where i can see these for example:

Maybe we could add it there as well somehow?

I know this wasn't mentioned in the original issue, but wouldn't it makes sense to show this message only to super users? The message already says to contact the administrator if it happens again, which should be enough for normal users.

Thanks for picking this up, yes, it would be important to only show the FAQ link to Super users 👍

@geekdenz
Copy link
Contributor Author

General_ErrorRequest

Yes, I had found quite a few references myself, but thought I'd ask in the PR before committing too much effort into it.

@geekdenz geekdenz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 20, 2021
core/View.php Outdated Show resolved Hide resolved
contributing to View::showMoreFaqInfo #15135
@geekdenz geekdenz added Needs Review PRs that need a code review and removed Needs Review PRs that need a code review labels Aug 23, 2021
@geekdenz geekdenz requested a review from sgiehl August 24, 2021 22:22
@geekdenz
Copy link
Contributor Author

Hi @sgiehl . Do you have time to look at this, please?

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@geekdenz geekdenz merged commit 5d5e630 into 4.x-dev Sep 4, 2021
@geekdenz geekdenz deleted the m-15135 branch September 4, 2021 07:20
@tassoman
Copy link
Contributor

How do I can disable this behaviour?
It's ok by overwriting the template by a ThemePlugin?
I don't want to bug administrators, but configured "From Recipient" installation global wide

@sgiehl
Copy link
Member

sgiehl commented Mar 23, 2023

I'm not sure what exactly you mean. The linked code is actually outdated. Meanwhile it's possible to configure a contact email address. See #17916

@tassoman
Copy link
Contributor

Ok! Fine! I wasn't aware of the new configuration, was exactly what I was looking for.
In the while, I was also able to override error message inside ajaxMacros.twig by putting an override into my ThemePlugin.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to a helpful FAQ in the error message "Oops, there was a problem during the request."
5 participants