Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add piwikHelper and define piwik.helper #17888

Merged
merged 2 commits into from Aug 16, 2021
Merged

add piwikHelper and define piwik.helper #17888

merged 2 commits into from Aug 16, 2021

Conversation

geekdenz
Copy link
Contributor

fixes #17787

there may well be a better way of including JS requirements
such as piwikHelper.js but this was quick and it might not be
desirable to dig too deep for this

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

fixes #17787

there may well be a better way of including JS requirements
such as piwikHelper.js but this was quick and it might not be
desirable to dig too deep for this
@geekdenz geekdenz added the Needs Review PRs that need a code review label Aug 15, 2021
@geekdenz geekdenz added this to the 4.5.0 milestone Aug 16, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

@sgiehl sgiehl merged commit 09c0123 into 4.x-dev Aug 16, 2021
@sgiehl sgiehl deleted the m-17787 branch August 16, 2021 10:12
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript console error when clicking Install routine: Download System Check button
4 participants