Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide segmented reports are pre-processed #17882

Merged
merged 9 commits into from Aug 26, 2021
Merged

hide segmented reports are pre-processed #17882

merged 9 commits into from Aug 26, 2021

Conversation

geekdenz
Copy link
Contributor

when enable_create_realtime_segments = 0
fixes #15036

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur removed the request for review from diosmosis August 13, 2021 00:11
@geekdenz geekdenz added the Needs Review PRs that need a code review label Aug 15, 2021
@geekdenz geekdenz added this to the 4.5.0 milestone Aug 15, 2021
@geekdenz geekdenz marked this pull request as ready for review August 15, 2021 22:22
@geekdenz geekdenz linked an issue Aug 15, 2021 that may be closed by this pull request
Removed misleading help text from segment dimensions tooltip #15322
Closed
sgiehl
sgiehl approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and works as expected. We could maybe add another UI test that checks the UI when the option is disabled to ensure it doesn't regress in the future

@justinvelluppillai
Copy link
Contributor

@geekdenz This PR is linked to #15036 and #15322, is that correct?

@geekdenz geekdenz removed a link to an issue Aug 16, 2021
Removed misleading help text from segment dimensions tooltip #15322
Closed
@geekdenz geekdenz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 19, 2021
@geekdenz geekdenz requested a review from sgiehl August 26, 2021 05:14
@sgiehl sgiehl merged commit 56ead71 into 4.x-dev Aug 26, 2021
@sgiehl sgiehl deleted the m-15036 branch August 26, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
4 participants
@geekdenz @justinvelluppillai @tsteur @sgiehl