Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions shows only partial data for URLs when multiple domains tracked to the same site #17875

Closed
diosmosis opened this issue Aug 11, 2021 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@diosmosis
Copy link
Member

NOTE: I looked for a duplicate but couldn't find an open issue.

Expected Behavior

If URLs with multiple domains are tracked to a single site, for example piwik1.net/some/path and piwik2.net/some/path, viewing /some/path in the Transitions UI should show data for both piwik1.net & piwik2.net URLs.

Current Behavior

Instead, only data for one URL is used. The URL that is chosen is the URL that ends up as the url metadata in the Actions.getPageUrls report. The action matching code in TableLogAction::getIdActionFromSegment doesn't ignore the host so only some data is selected.

Possible Solution

Some possible solutions:

  • look for idactions where the name ends in the path, rather than just the given URL. (may be a performance hit, especially if patching core logic)
  • store every URL host tracked somewhere in the actions report (would require re-archiving for users affected)
  • process this data with Actions.getPageUrls archiving (from a quick look, it seems possible to process this data as we aggregate over log_link_visit_action)

Steps to Reproduce (for Bugs)

  1. track a visit to a site with the URL http://piwik1.net/some/path
  2. track a visit to the same site with the URL http://piwik2.net/some/path
  3. view the transitions report for /some/path. The pageviews count in the dropdown will be correct, the pageviews count in the main visualization will be incorrect.

NOTE: This bug is visible in our Transitions UI tests.

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 11, 2021
@diosmosis
Copy link
Member Author

From our UI test:

image

See 24 vs 14

@webberian
Copy link

Duplicate of #15039?

@mattab
Copy link
Member

mattab commented Dec 10, 2023

Duplicate of #15039 - thanks @webberian @diosmosis for the comments!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

4 participants