Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple a possible warnings in PHP 8.1 #17869

Merged
merged 1 commit into from Aug 10, 2021
Merged

Fix a couple a possible warnings in PHP 8.1 #17869

merged 1 commit into from Aug 10, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 10, 2021

Description:

refs #17686

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.5.0 milestone Aug 10, 2021
@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 10, 2021
@sgiehl sgiehl marked this pull request as ready for review August 10, 2021 08:23
@sgiehl sgiehl mentioned this pull request Aug 10, 2021
Closed
38 tasks
@diosmosis diosmosis merged commit 1156eb9 into 4.x-dev Aug 10, 2021
@diosmosis diosmosis deleted the php81fixes branch August 10, 2021 23:53
@Findus23 Findus23 mentioned this pull request Aug 11, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis