Use Monolog:SyslogHandler syslog default facility #17855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue#9400
Avoid null in ErrorLogHandler constructor call: Use level param; default others
|
@mwithheld I think you'll need to merge these changes w/ 4.x-dev to remove the conflicts, something like: |
diosmosis
reviewed
Aug 5, 2021
diosmosis
reviewed
Aug 5, 2021
plugins/Monolog/config/config.php
Outdated
| @@ -105,7 +105,8 @@ | |||
| ->method('setFormatter', DI\get('log.lineMessageFormatter.file')), | |||
|
|
|||
| '\Monolog\Handler\SyslogHandler' => DI\create() | |||
| ->constructor(DI\get('log.syslog.ident'), 'syslog', DI\get('log.level.syslog')) | |||
| ->constructorParameter('ident' => DI\get('log.syslog.ident')) | |||
There was a problem hiding this comment.
Suggested change
| ->constructorParameter('ident' => DI\get('log.syslog.ident')) | |
| ->constructorParameter('ident', DI\get('log.syslog.ident')) |
diosmosis
reviewed
Aug 5, 2021
plugins/Monolog/config/config.php
Outdated
| @@ -105,7 +105,8 @@ | |||
| ->method('setFormatter', DI\get('log.lineMessageFormatter.file')), | |||
|
|
|||
| '\Monolog\Handler\SyslogHandler' => DI\create() | |||
| ->constructor(DI\get('log.syslog.ident'), 'syslog', DI\get('log.level.syslog')) | |||
| ->constructorParameter('ident' => DI\get('log.syslog.ident')) | |||
| ->constructorParameter('level' => DI\get('log.level.syslog')) | |||
There was a problem hiding this comment.
Suggested change
| ->constructorParameter('level' => DI\get('log.level.syslog')) | |
| ->constructorParameter('level', DI\get('log.level.syslog')) |
|
@mwithheld left a couple suggestions, after those I should be able to merge it. |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
|
Hi @mwithheld, sorry for the late reply, it seems like you added some commits for another PR into this one (the one dealing w/ NotSupportedBrowserException). |
github-actions
bot
removed
the
Stale
|
Good catch - I've reset the branch to before the incorrect ones, force-pushed the branch, and merged updates from the 4.x-dev branch. Hopefully that is clean now. |
|
Thanks for fixing up the PR @mwithheld! It's now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a further fix to #17764, fixing the Monolog:SyslogHandler create() call to use its constructor-default facility rather than manually setting it to 'syslog' incorrectly.