Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better checks when shell_exec is disabled #17840

Merged
merged 1 commit into from Jul 30, 2021
Merged

better checks when shell_exec is disabled #17840

merged 1 commit into from Jul 30, 2021

Conversation

diosmosis
Copy link
Member

Description:

Fixes #17838

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 29, 2021
@diosmosis diosmosis added this to the 4.4.1 milestone Jul 29, 2021
@tsteur
Copy link
Member

tsteur commented Jul 30, 2021

@diosmosis looks good 👍 There is this test failing not sure if it's related to this change? https://app.travis-ci.com/github/matomo-org/matomo/jobs/527845639#L772 and https://app.travis-ci.com/github/matomo-org/matomo/jobs/527845645#L919

@tsteur
Copy link
Member

tsteur commented Jul 30, 2021

actually I looked in branch and not PR check, will merge

@tsteur tsteur merged commit 617e21e into 4.x-dev Jul 30, 2021
@tsteur tsteur deleted the 17838-shell-exec branch July 30, 2021 02:40
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

More warnings about missing shell_exec() since Matomo 4.4.0
3 participants
@diosmosis @tsteur @mattab