Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More warnings about missing shell_exec() since Matomo 4.4.0 #17838

Closed
Findus23 opened this issue Jul 29, 2021 · 1 comment · Fixed by #17840
Closed

More warnings about missing shell_exec() since Matomo 4.4.0 #17838

Findus23 opened this issue Jul 29, 2021 · 1 comment · Fixed by #17840
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.4.1

Comments

@Findus23
Copy link
Member

reported in
https://forum.matomo.org/t/warning-shell-exec-has-been-disabled-for-security-reasons-matomo-4-4-0/42661 (two users)
and
https://forum.matomo.org/t/error-after-update-to-v4-4-0/42679

It seems like this is maybe caused by #17576
@Findus23 Findus23 added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 29, 2021
@Findus23 Findus23 added this to the 4.4.1 milestone Jul 29, 2021
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 29, 2021
@tsteur
Copy link
Member

tsteur commented Jul 29, 2021

It be good to add a function_exists('shell_exec') before these calls 👍 and also make sure warnings are suppressed using @shell_exec 👍

@diosmosis diosmosis self-assigned this Jul 29, 2021
@diosmosis diosmosis mentioned this issue Jul 29, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.4.1
Development

Successfully merging a pull request may close this issue.

better checks when shell_exec is disabled matomo-org/matomo
3 participants
@diosmosis @tsteur @Findus23