Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of Geolocation providers #17835

Merged
merged 2 commits into from Aug 1, 2021
Merged

Fix sorting of Geolocation providers #17835

merged 2 commits into from Aug 1, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 29, 2021

Description:

Geolocation providers can be defined together with an order. This flag is used to sort the providers to generate the list of all providers. Currently when two providers have the same order flag, the second provider will replace the first on in the list. Currently this can cause problems when installing a new provider (like IP2Location), as the currently used geoip2php suddenly gets unavailable.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jul 29, 2021
@sgiehl sgiehl added this to the 4.4.1 milestone Jul 29, 2021
@diosmosis
Copy link
Member

Could this benefit from a quick test?

@sgiehl
Copy link
Member Author

sgiehl commented Jul 30, 2021

@diosmosis Added some simple tests. The second one would currently fail on 4.x-dev

@diosmosis diosmosis merged commit 8e94678 into 4.x-dev Aug 1, 2021
@diosmosis diosmosis deleted the providersort branch August 1, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants