Fix sorting of Geolocation providers #17835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Geolocation providers can be defined together with an
order
. This flag is used to sort the providers to generate the list of all providers. Currently when two providers have the same order flag, the second provider will replace the first on in the list. Currently this can cause problems when installing a new provider (like IP2Location), as the currently used geoip2php suddenly gets unavailable.Review