@sgiehl opened this Pull Request on July 29th 2021 Member

Description:

Geolocation providers can be defined together with an order. This flag is used to sort the providers to generate the list of all providers. Currently when two providers have the same order flag, the second provider will replace the first on in the list. Currently this can cause problems when installing a new provider (like IP2Location), as the currently used geoip2php suddenly gets unavailable.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 29th 2021 Member

Could this benefit from a quick test?

@sgiehl commented on July 30th 2021 Member

@diosmosis Added some simple tests. The second one would currently fail on 4.x-dev

This Pull Request was closed on August 1st 2021
Powered by GitHub Issue Mirror