@tsteur opened this Pull Request on July 29th 2021 Member

Description:

Needed for https://github.com/matomo-org/developer-documentation/pull/498

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on July 29th 2021 Member

Because the example plugin is neither in the release nor do we actually add the diagnostic check this should be fine to merge in 4.4.1 maybe. Otherwise can do in Matomo 4.5.0. Added some documentation in https://github.com/matomo-org/developer-documentation/pull/498

@tsteur commented on July 29th 2021 Member

Thanks @sgiehl 👍 applied the patch

This Pull Request was closed on July 30th 2021
Powered by GitHub Issue Mirror