Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to generate a system check #17832

Merged
merged 3 commits into from Jul 30, 2021
Merged

Add command to generate a system check #17832

merged 3 commits into from Jul 30, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 29, 2021

Description:

Needed for matomo-org/developer-documentation#498

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur mentioned this pull request Jul 29, 2021
Merged
@tsteur tsteur marked this pull request as draft July 29, 2021 04:51
@tsteur tsteur marked this pull request as ready for review July 29, 2021 04:57
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 29, 2021
@tsteur tsteur added this to the 4.4.1 milestone Jul 29, 2021
@tsteur
Copy link
Member Author

tsteur commented Jul 29, 2021

Because the example plugin is neither in the release nor do we actually add the diagnostic check this should be fine to merge in 4.4.1 maybe. Otherwise can do in Matomo 4.5.0. Added some documentation in matomo-org/developer-documentation#498

@tsteur @sgiehl
Update plugins/CoreConsole/Commands/GenerateSystemCheck.php
5a0c566 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@tsteur
Copy link
Member Author

tsteur commented Jul 29, 2021

Thanks @sgiehl 👍 applied the patch

@diosmosis diosmosis merged commit af066cb into 4.x-dev Jul 30, 2021
@diosmosis diosmosis deleted the generatesystemcheckcmd branch July 30, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @diosmosis