The issue is reproducible calling
_paq.push(['setCookieDomain', 'custom.matomo.dev']);, which tries to set and remove a cookie on the given domain.
is it possible to test this?
Does the test fail if any errors are logged during the execution?
@Findus23 I'm not sure, but unless an exception is thrown, I doubt it.
setCookieDomain is used, and it actually throws that error on console multiple times. But those errors are ignored and might be hard to test. Guess we would need to overwrite
console.log in order to be able to get and compare the log message. Will check if that's fast to implement...
Tried writing some tests for a while now, but for some reason the error message is not triggered when I would expect it (like setting an invalid cookie domain). It's only triggered when a cookie is deleted, which should be fixed with the changes here...
@sgiehl if the test fails in 4.x-dev then it's still useful, right? If it's not possible though then I guess it's not vital.
maybe we should consider adding some proper tests for the cookie methods
later. For some reasons they didn't trigger a console error when I would
have expected it. But maybe my expectations were wrong. Feel free to have a
look yourself Dizzy if you have some time today...
Added a test that fails on 4.x-dev but passes on this branch. Will merge now.