@diosmosis opened this Pull Request on July 27th 2021 Member

Description:

Applying row limits to product reports as we do to most other reports. This PR does not include the use of ranking query, just two new INI config options to limit the report sizes.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 28th 2021 Member

:+1: makes sense to

@tsteur commented on July 28th 2021 Member

@sgiehl it'll be mentioned in the regular changelog later as part of the release

@mattab commented on July 30th 2021 Member

Ideally we would set it to a higher value by default, as Ecommerce store owners have an expectation that the product report is accurate, and 500 products out of say 10,000 unique products would be quite inaccurate. For User ID we set a limit of 50,000. Maybe we could set 10,000 for products?

@diosmosis commented on July 30th 2021 Member

Updated. Also removed the subtable setting since the products reports don't have subtab.es.

This Pull Request was closed on August 4th 2021
Powered by GitHub Issue Mirror