New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit the size of product reports #17823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty straightforward. Do we need to mention these new settings in any documentation (eg here https://matomo.org/faq/how-to/faq_54/)?
👍 makes sense to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we need to mention that in any changelog? Before the report was actually unlimited and now it's truncated to 500 by default. The change might be relevant for those tracking more than 500 different products...
@sgiehl it'll be mentioned in the regular changelog later as part of the release |
Ideally we would set it to a higher value by default, as Ecommerce store owners have an expectation that the product report is accurate, and 500 products out of say 10,000 unique products would be quite inaccurate. For User ID we set a limit of 50,000. Maybe we could set 10,000 for products? |
Updated. Also removed the subtable setting since the products reports don't have subtab.es. |
Description:
Applying row limits to product reports as we do to most other reports. This PR does not include the use of ranking query, just two new INI config options to limit the report sizes.
Review