Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of stashed datatables before going into safe mode to free up memory #17818

Merged
merged 1 commit into from Aug 2, 2021

Conversation

diosmosis
Copy link
Member

Description:

In out of memory fatal errors we try to trigger safemode and print out a partial stack trace. However, we'll generally not have the memory to actually do this, so we just trigger another out of memory error that is not handled. To alleviate this, this PR will remove every datatable in memory (as this is usually the cause of out of memory errors). Hopefully this will create a useful trace in the output.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 27, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that's worth a try.

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 28, 2021
@diosmosis diosmosis added this to the 4.5.0 milestone Jul 28, 2021
@diosmosis diosmosis merged commit 8e1bee4 into 4.x-dev Aug 2, 2021
@diosmosis diosmosis deleted the safemode-datatables branch August 2, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants