@diosmosis opened this Pull Request on July 27th 2021 Member

Description:

In out of memory fatal errors we try to trigger safemode and print out a partial stack trace. However, we'll generally not have the memory to actually do this, so we just trigger another out of memory error that is not handled. To alleviate this, this PR will remove every datatable in memory (as this is usually the cause of out of memory errors). Hopefully this will create a useful trace in the output.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on August 2nd 2021
Powered by GitHub Issue Mirror