New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When aggregating reports, inflate one expanded datatable at a time #17817
Conversation
… time, rather than all at once
…n datatables (as this will mean sharing subtable instances as well)
Transitions screenshot change is not correct, but it is due to an unrelated bug: #17875 |
plugins/Contents/tests/System/expected/test_Contents__Actions.getPageUrls_month.xml
Show resolved
Hide resolved
@sgiehl removed the debugging code and fixed some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tests seem to be passing again 👍
Not sure if maybe @tsteur wants to have another quick look before merging?
Looks good to me @diosmosis 👍 Great, this will reduce memory quite a bit 💯 |
Description:
Currently when aggregating reports over multi periods, we get the blob data for every child period, inflate the blob data for every period into a DataTable tree, then add them together. Afterwards we clean up the extra DataTables, but in the meantime a lot of memory is used, especially when the reports are large. This PR switches to inflating the DataTable tree for just one period at a time and should use less memory overall.
Review