Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing null to non-nullable arguments of internal functions #17813

Closed
wants to merge 1 commit into from
Closed

Conversation

mwithheld
Copy link
Contributor

Issue #17686 Deprecate passing null to non-nullable arguments of internal functions

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

Issue #17686 Deprecate passing null to non-nullable arguments of internal functions
@mwithheld mwithheld closed this Jul 25, 2021
@mwithheld mwithheld deleted the patch-7 branch July 25, 2021 21:38
@Findus23
Copy link
Member

This has now been replaced with #17869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants