Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Matomo icons submodule #17811

Merged
merged 3 commits into from Aug 4, 2021
Merged

update Matomo icons submodule #17811

merged 3 commits into from Aug 4, 2021

Conversation

Findus23
Copy link
Member

I'm sorry that this will possibly break quite a few UI tests, but I noticed that quite a lot of major companies rebranded since I added the logos initially and have now updated all the important ones I could find in one go.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 25, 2021
@Findus23 Findus23 marked this pull request as draft July 25, 2021 14:37
@Findus23 Findus23 marked this pull request as ready for review July 25, 2021 14:47
@sgiehl sgiehl added this to the 4.5.0 milestone Jul 28, 2021
@sgiehl sgiehl mentioned this pull request Jul 28, 2021
Merged
@sgiehl sgiehl merged commit 712b43e into 4.x-dev Aug 4, 2021
@sgiehl sgiehl deleted the update-icons-07-2021 branch August 4, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @sgiehl