@sgiehl opened this Pull Request on July 23rd 2021 Member

Description:

Actually I'm not totally sure if the changes might be to restrictive or if we could restrict some actions a bit more. Maybe write access to pull requests/issues would not be needed, if only commits are added and no comments.

Note: Setting permissions to none would actually not be needed, as that's the default as soon as another permission is set. I left them in, so it's clear which permissions are available and set.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on August 4th 2021 Member

I'll merge this now. If any action fails in the future we can check if the permissions are too restrictive later...

This Pull Request was closed on August 4th 2021
Powered by GitHub Issue Mirror