@sgiehl opened this Pull Request on July 23rd 2021 Member

Description:

report.idsegment might be null when received from API. To ensure the default value is selected in that case, we need to convert that to an empty string.

fixes #15335

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 25th 2021 Member

I don't think this is specifically related, but testing locally when I tried to update a report I got: Please specify a value for 'reports'.. The HTTP request doesn't appear to have that parameter but ScheduledReports.updateReport requires it.

@sgiehl commented on July 28th 2021 Member

@diosmosis That works for me. Did you maybe try to edit a report where no reports were chosen in the list? Maybe they became unavailable 🤔

@diosmosis commented on July 28th 2021 Member

@sgiehl yep, that's what happened, not sure how though.

This Pull Request was closed on August 2nd 2021
Powered by GitHub Issue Mirror