Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing Mail test #17806

Merged
merged 1 commit into from Jul 22, 2021
Merged

Fix failing Mail test #17806

merged 1 commit into from Jul 22, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 22, 2021

Description:

Seems to be a regression from #17800

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 22, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jul 22, 2021
@sgiehl sgiehl requested a review from diosmosis July 22, 2021 15:52
@diosmosis diosmosis merged commit 06d5f0e into 4.x-dev Jul 22, 2021
@diosmosis diosmosis deleted the fixmailtest branch July 22, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis