Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If visit local time is null do not fail in report fetch API method #17801

Merged
merged 1 commit into from Aug 4, 2021
Merged

If visit local time is null do not fail in report fetch API method #17801

merged 1 commit into from Aug 4, 2021

Conversation

diosmosis
Copy link
Member

Description:

Fixes #17796

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jul 21, 2021
@diosmosis diosmosis added this to the 4.5.0 milestone Jul 21, 2021
@diosmosis diosmosis mentioned this pull request Jul 21, 2021
Closed
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 23, 2021
@sgiehl sgiehl modified the milestones: 4.6.0, 4.5.0 Jul 28, 2021
@diosmosis diosmosis merged commit 8161ae7 into 4.x-dev Aug 4, 2021
@diosmosis diosmosis deleted the 17796-visit-localtime-null branch August 4, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.5.0
2 participants
@diosmosis @sgiehl