Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not introduce breaking change in Mail.send #17800

Merged
merged 3 commits into from Jul 21, 2021
Merged

do not introduce breaking change in Mail.send #17800

merged 3 commits into from Jul 21, 2021

Conversation

diosmosis
Copy link
Member

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jul 21, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jul 21, 2021
@sgiehl sgiehl merged commit 51ce3db into 4.x-dev Jul 21, 2021
@sgiehl sgiehl deleted the mail-send-non-breaking branch July 21, 2021 13:50
@sgiehl sgiehl mentioned this pull request Jul 22, 2021
Merged
10 tasks
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @tsteur @sgiehl @mattab