Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reading IP address, do not ignore remote_addr if reading the last ip in proxy header lists #17790

Merged
merged 1 commit into from Jul 20, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 19, 2021

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Jul 19, 2021
@tsteur tsteur added this to the 4.4.0 milestone Jul 19, 2021
@tsteur tsteur merged commit 78387db into 4.x-dev Jul 20, 2021
@tsteur tsteur deleted the do-not-ignore-remote_addr branch July 20, 2021 02:29
@mattab mattab changed the title do not ignore remote_addr if reading the last ip in proxy header lists When reading IP address, do not ignore remote_addr if reading the last ip in proxy header lists Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants