Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error messages not leak potentially sensitive information when db connection fails #17789

Merged
merged 8 commits into from Jul 19, 2021
Merged

Make error messages not leak potentially sensitive information when db connection fails #17789

merged 8 commits into from Jul 19, 2021

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Improve DB connection issue messages and provide framework for later improvements if any.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jul 18, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jul 18, 2021
diosmosis
diosmosis reviewed Jul 18, 2021
View reviewed changes
core/Db/Adapter.php Outdated Show resolved Hide resolved
@justinvelluppillai justinvelluppillai modified the milestones: 4.4.0, 4.5.0 Jul 19, 2021
tsteur
tsteur reviewed Jul 19, 2021
View reviewed changes
lang/en.json Outdated Show resolved Hide resolved
@justinvelluppillai
More test fixes
69df178
@justinvelluppillai
Update en.json
580eeb9 
Use MySQL server has gone away to help people google the fix
@diosmosis
Copy link
Member

tested locally, looks good to me 👍

@diosmosis diosmosis merged commit 9aea154 into 4.x-dev Jul 19, 2021
@diosmosis diosmosis deleted the helpful-db-msgs branch July 19, 2021 18:21
@diosmosis diosmosis modified the milestones: 4.5.0, 4.4.0 Jul 19, 2021
@mattab mattab changed the title More helpful messages on db connection failures Make error messages not leak potentially sensitive information when db connection fails Jul 28, 2021
@mattab mattab added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Jul 28, 2021
@tsteur tsteur mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinvelluppillai @diosmosis @tsteur @mattab