Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript console error when clicking Install routine: Download System Check button #17787

Closed
math-GH opened this issue Jul 17, 2021 · 2 comments · Fixed by #17888
Closed

Javascript console error when clicking Install routine: Download System Check button #17787

math-GH opened this issue Jul 17, 2021 · 2 comments · Fixed by #17888
Assignees
@geekdenz
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Milestone
4.5.0

Comments

@math-GH
Copy link

math-GH commented Jul 17, 2021

Install routine
Page 2

Button "Download System Check"

Does not work. JavaScript error.
grafik

Expected Behavior

download works without an JavaScript error

Current Behavior

download does not work

Your Environment

  • Matomo Version: 4.3.1
  • Browser: Firefox 90
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 17, 2021
@Findus23 Findus23 added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 17, 2021
@Findus23
Copy link
Member

I guess

matomo/plugins/Morpheus/javascripts/piwikHelper.js

Line 32 in 2b35b46

sendContentAsDownload: function (filename, content, mimeType) {

is not included in the installation page

@tsteur tsteur added this to the 4.4.0 milestone Jul 18, 2021
@tsteur
Copy link
Member

tsteur commented Jul 18, 2021

👍 and/or it needs to be piwikHelper instead of piwik.helper

@mattab mattab modified the milestones: 4.4.0, 4.5.0 Jul 28, 2021
@geekdenz geekdenz self-assigned this Aug 10, 2021
geekdenz pushed a commit that referenced this issue Aug 14, 2021
add piwikHelper and define piwik.helper fixes #17787
89b8f68
geekdenz pushed a commit that referenced this issue Aug 14, 2021
add piwikHelper and define piwik.helper
df9eeb6 
fixes #17787

there may well be a better way of including JS requirements
such as piwikHelper.js but this was quick and it might not be
desirable to dig too deep for this
@geekdenz geekdenz mentioned this issue Aug 14, 2021
Merged
10 tasks
geekdenz pushed a commit that referenced this issue Aug 15, 2021
refactor piwikHelper.js to controller #17787
6916674
@geekdenz geekdenz added the Needs Review PRs that need a code review label Aug 15, 2021
sgiehl pushed a commit that referenced this issue Aug 16, 2021
add piwikHelper and define piwik.helper (#17888)
09c0123 
* add piwikHelper and define piwik.helper

fixes #17787

there may well be a better way of including JS requirements
such as piwikHelper.js but this was quick and it might not be
desirable to dig too deep for this

* refactor piwikHelper.js to controller #17787
@justinvelluppillai justinvelluppillai changed the title Install routine: Download System Check: JavaScript: Uncaught TypeError: piwik.helper is undefined Javascript console error when clicking Install routine: Download System Check button Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekdenz geekdenz

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

add piwikHelper and define piwik.helper matomo-org/matomo
5 participants
@tsteur @mattab @geekdenz @math-GH @Findus23