Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install routine: language changer line height improvements #17786

Closed
math-GH opened this issue Jul 17, 2021 · 1 comment · Fixed by #18165
Closed

Install routine: language changer line height improvements #17786

math-GH opened this issue Jul 17, 2021 · 1 comment · Fixed by #18165
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.6.0

Comments

@math-GH
Copy link

math-GH commented Jul 17, 2021 •
edited

grafik

Expected Behavior

smaller gap between line 1 and 2

Current Behavior

big gap (line-height: 30px)

grafik

Possible Solution

.menuDropdown .items .item {
  padding: 12px 25px 12px 6px !important;
  line-height: 16px;
}

grafik

Your Environment

  • Matomo Version: 4.3.1
  • Browser: Firefox 90
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 17, 2021
@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 17, 2021
@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2021

@mathContao Thanks for your report. If you have tested your possible solution, feel free to simply create a Pull Request to fix it.

@donovanglover donovanglover mentioned this issue Oct 15, 2021
Merged
sgiehl pushed a commit that referenced this issue Oct 18, 2021
@donovanglover
Fix menu dropdown spacing (#18165)
1558764 
Fixes #17786.
@justinvelluppillai justinvelluppillai changed the title Install routine: language changer: line height Install routine: language changer line height improvements Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Fix menu dropdown spacing
5 participants
@tsteur @justinvelluppillai @sgiehl @math-GH @Findus23