Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install routine UI: improve text contrast #17785

Closed
math-GH opened this issue Jul 17, 2021 · 0 comments · Fixed by #18164
Closed

Install routine UI: improve text contrast #17785

math-GH opened this issue Jul 17, 2021 · 0 comments · Fixed by #18164
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@math-GH
Copy link

math-GH commented Jul 17, 2021

Install routine: text color

grafik
(checked with the development tool in Firefox)

Expected Behavior

darker grey (better: black), that has a much better contrast

Current Behavior

grey font color with low contrast.
font-color: #858585 (contrast ratio: 3.7)

Possible Solution

font-color: #757575 (contrast ratio: 4.5 => minimum ratio https://developer.mozilla.org/en-US/docs/Web/Accessibility/Understanding_WCAG/Perceivable/Color_contrast)

Your Environment

  • Matomo Version: 4.3.1
  • Browser: Firefox 90
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jul 17, 2021
@Findus23 Findus23 added c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jul 17, 2021
@math-GH math-GH changed the title Install routine: text contrast is to low Install routine: text contrast is too low Jul 17, 2021
@donovanglover donovanglover mentioned this issue Oct 15, 2021
Merged
sgiehl added a commit that referenced this issue Oct 28, 2021
@donovanglover @sgiehl
Install routine: Fix text contrast for accessibility (#18164)
9357cc9 
* Install routine: Fix text contrast for accessibility

Fixes #17785.

* Make label color same as text during installation

* trigger build

Co-authored-by: Stefan Giehl <stefan@matomo.org>
@justinvelluppillai justinvelluppillai changed the title Install routine: text contrast is too low Install routine UI: improve text contrast Nov 29, 2021
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install routine: Fix text contrast for accessibility
3 participants
@justinvelluppillai @math-GH @Findus23