@sgiehl opened this Pull Request on July 16th 2021 Member

Description:

fixes #17776

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 18th 2021 Member

can we add a test for this?

@sgiehl commented on July 19th 2021 Member

@diosmosis I've added a bunch of tests for all API methods of that plugin and directly fixed some other API methods that also failed with multiple sites and multiple dates.

This Pull Request was closed on July 19th 2021
Powered by GitHub Issue Mirror