Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter in UserCountry.getCountry for Map of Maps #17779

Merged
merged 2 commits into from Jul 19, 2021
Merged

Fix filter in UserCountry.getCountry for Map of Maps #17779

merged 2 commits into from Jul 19, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 16, 2021

Description:

fixes #17776

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 16, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jul 16, 2021
@diosmosis
Copy link
Member

can we add a test for this?

@sgiehl
Copy link
Member Author

sgiehl commented Jul 19, 2021

@diosmosis I've added a bunch of tests for all API methods of that plugin and directly fixed some other API methods that also failed with multiple sites and multiple dates.

@diosmosis diosmosis merged commit 385b036 into 4.x-dev Jul 19, 2021
@diosmosis diosmosis deleted the fixgetcountry branch July 19, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Call to undefined method Piwik\\DataTable\\Map::getRowFromLabel() in plugins/UserCountry/API.php
2 participants
@sgiehl @diosmosis