check plugin exists in the filesystem on plugin activate command #17772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
tsteur
reviewed
Jul 14, 2021
sgiehl
requested changes
Jul 15, 2021
Comment on lines
41
to
44
| if (!$pluginManager->isPluginInFilesystem($plugin)) { | ||
| $output->writeln("<error>Cannot find plugin files for $plugin.</error>"); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Does that check make sense here?
If a plugin name is provided that was never installed (is not included in plugin list in config.ini.php), the method will already fail with already deactivated. If it was installed, but only removed from file system it might make sense to allow a deactivation so it gets removed from the plugin list in config.ini.php and it's no longer tried to load it anymore.
|
@sgiehl updated |
diosmosis
changed the title
sgiehl
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a plugin doesn't have a Plugin class, the plugin manager just uses
new Plugin($pluginName). CallinggetMissingDependencies()immediately after triggers the plugin install code path, which adds the nonexistent plugin to the INI config. Now we check and provide a clear error message in the commands, and make sure we only try to load plugins that exist in the filesystem.Fixes #17770
Review