@diosmosis opened this Pull Request on July 14th 2021 Member

Description:

If a plugin doesn't have a Plugin class, the plugin manager just uses new Plugin($pluginName). Calling getMissingDependencies() immediately after triggers the plugin install code path, which adds the nonexistent plugin to the INI config. Now we check and provide a clear error message in the commands, and make sure we only try to load plugins that exist in the filesystem.

Fixes #17770

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 18th 2021 Member

@sgiehl updated

This Pull Request was closed on July 19th 2021
Powered by GitHub Issue Mirror