@diosmosis opened this Pull Request on July 13th 2021 Member

Description:

Fixes L3-123.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on July 13th 2021 Member

Before merging once the config is final be good to document this security feature in https://matomo.org/faq/how-to-install/faq_98/ and maybe in https://matomo.org/docs/security-how-to/ we could as well mention that they might want to enable this config if they are using a load balancer.

@mattab you will want to document this in the enterprise guide probably as well.

@diosmosis commented on July 14th 2021 Member

@sgiehl / @tsteur applied review feedback

@mattab commented on July 15th 2021 Member

@mattab you will want to document this in the enterprise guide probably as well.

Sounds good, let me know when the user guide is updated and i'll copy the information in the PDF enterprise guide.

@tsteur commented on July 16th 2021 Member

@mattab added a bit to the docs

This Pull Request was closed on July 16th 2021
Powered by GitHub Issue Mirror