Issue #9400 Add log handlers syslog and errorlog; Add config for syslog ident; Document options.
@mwithheld Thanks for fixing the issues! I left one other comment. After it's addressed it should be good to merge.
Added commit 14992a8 ErrorLogHandler constructor: Avoid null
Good catch - the discussion is welcome :) That was not intended - I'm just
not used to using GitHub for editing PRs.
On Thu, Jul 15, 2021 at 7:20 PM dizzy @.***> wrote:
@.**** commented on this pull request.
@@ -97,6 +99,13 @@
'Piwik\Plugins\Monolog\Handler\FileHandler' => DI\create()
- '\Monolog\Handler\ErrorLogHandler' => DI\create()
- ->constructorParameter('level', DI\get('log.level.errorlog'))
- ->method('setFormatter', DI\get('log.lineMessageFormatter.file')),
- '\Monolog\Handler\SyslogHandler' => DI\create()
- ->constructor(DI\get('log.syslog.ident'), 'syslog', DI\get('log.level.syslog')),
Apologies for the back and forth, but one last question here: was it
intentional not to use ->method('setFormatter',
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
@mwithheld I've merged the PR, thanks for going through the trouble of creating the PR and following up on it! The contribution is greatly appreciated.
Hi @mwithheld, thanks for creating the change so quickly! Would you be able to put it in a new pull request? This one has already been merged so it's no longer useful to push here.
Ok, thanks! And thanks for adding syslog support in the first place. Obviously, I was waiting for it =)