Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible warning that session is not active for anonymous user #17758

Merged
merged 2 commits into from Jul 13, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 12, 2021

Description:

In case of an API request the session might be started but closed again right away. Therefor we need to check if it's writable to check if we need to initialize the session auth.

fixes #17737

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 12, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jul 12, 2021
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test failure, otherwise it looks good

@sgiehl sgiehl merged commit fa66bc5 into 4.x-dev Jul 13, 2021
@sgiehl sgiehl deleted the anonsess branch July 13, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning - session_regenerate_id(): Cannot regenerate session id - session is not active
2 participants