Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide console command for version information (#17755) #17757

Merged
merged 1 commit into from Jul 18, 2021
Merged

provide console command for version information (#17755) #17757

merged 1 commit into from Jul 18, 2021

Conversation

ziegenberg
Copy link
Contributor

Description:

Adds a new console command core:version which outputs only the bare version information (#17755).

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@ziegenberg
provide console command for version information (matomo-org#17755)
b07e439 
* adds a new console command core:version which outputs only the bare version information

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the 17755-version-console-command branch from c6bc978 to b07e439 Compare July 12, 2021 07:09
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 12, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jul 18, 2021
@diosmosis
Copy link
Member

Thanks @ziegenberg for the contribution! The change looks good to me, and we could eventually add the ability to print out plugin versions and other component versions, so seems like a good change.

@diosmosis diosmosis merged commit a664172 into matomo-org:4.x-dev Jul 18, 2021
@diosmosis diosmosis mentioned this pull request Jul 18, 2021
Closed
@ziegenberg ziegenberg deleted the 17755-version-console-command branch July 20, 2021 06:32
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ziegenberg @diosmosis @mattab @sgiehl