New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17417 cookie domain #17744
17417 cookie domain #17744
Conversation
build js |
Tested locally via the test-examples repo, after adding the following code:
And viewing the page on the On 4.x-dev, |
@diosmosis I think that issue is because you are trying to set cookies on a top level domain (.matomotestexamples). Other than that your results are as I expect. |
@justinvelluppillai would you know why it works without your changes and sets the cookie correctly, but doesn't w/ the changes? I don't see anything in the code that could cause this, but it is reproducible. |
@diosmosis it used to set the cookie on the wrong domain, ignoring the setCookieDomain directive. On the new it doesn't ignore the setCookieDomain directive and tries to set the cookie on the domain specified, but you have specified a top level domain on which it can't set a cookie, therefore it doesn't set the cookie on the new. Once you change the test domains to for example www.matomotestexamples.matomo and .matomotestexamples.matomo it will work |
@justinvelluppillai I see, thanks for the explanation! |
@justinvelluppillai fyi, there are still some JSLint errors it seems |
build js |
build js |
build js |
Passing js tests now @diosmosis - took me a few iterations of adding semicolons to get it through the jslint-ing. |
Description:
Fixes #17417 by setting the cookie domain (configCookieDomain) even when cookies are disabled.
Also checks whether setCookie is able to successfully create a cookie and if not, log a console message for visibility.
Build js
Review