Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preselection in site selector form fields #17742

Merged
merged 2 commits into from Jul 8, 2021
Merged

Fix preselection in site selector form fields #17742

merged 2 commits into from Jul 8, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 7, 2021

Description:

Currently the selected site (form field value) is not correctly passed to the site selector field, resulting in a selection of the default site.

fixes matomo-org/plugin-CustomAlerts#53

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 7, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jul 7, 2021
@diosmosis diosmosis merged commit de01ea3 into 4.x-dev Jul 8, 2021
@diosmosis diosmosis deleted the fixsiteselector branch July 8, 2021 22:41
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

When editing a custom alert, the site selector is not set to the alert's configured site
3 participants
@sgiehl @diosmosis @mattab