@diosmosis opened this Pull Request on July 5th 2021 Member

Description:

Fixes #17732

Changes:

  • impose limit on notification message size when logging to notifications
  • if in memory notification count exceeds max notification size in session, do not attempt to new ones it to the session
  • Detect when session was too large to read and provide warning to user.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on July 6th 2021 Member

@sgiehl I added some relevant tests. I didn't add tests for all of DbTable.php or Notification\Manager.php, they were completely untested before. That might be good to do eventually.

@sgiehl commented on July 7th 2021 Member

@sgiehl I added some relevant tests. I didn't add tests for all of DbTable.php or Notification\Manager.php, they were completely untested before. That might be good to do eventually.

guess we could create a new issue for creating more/better tests for that

@diosmosis commented on July 7th 2021 Member
@github-actions[bot] commented on July 15th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on July 18th 2021 Member

@sgiehl @tsteur changed the session column type

@diosmosis commented on July 19th 2021 Member

@sgiehl updated

@sgiehl commented on July 19th 2021 Member

Should be good to merge if tests are passing again now

@tsteur commented on July 20th 2021 Member

As it's quite a big PR / change let's maybe merge it after the Matomo 4.4 release (as there have been already two RC releases and the release is due soon)

Powered by GitHub Issue Mirror