@justinvelluppillai opened this Pull Request on July 5th 2021 Contributor

Description:

fixes #17454

The setting in firefox to delete cookies when firefox closes causes navigator.serviceWorker.ready to fail and firefox gives the operation is insecure error. This change silences the error by handling the rejected promise with the second argument to the .then() function.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on July 5th 2021 Member

build js

@justinvelluppillai commented on July 5th 2021 Contributor

build js

@justinvelluppillai commented on July 5th 2021 Contributor

To test this open a page with matomo tracking js on it, go offline then back online again (eg turn wifi off/on) and without this change you will see a console error, with this change you shouldn't.

@diosmosis commented on July 5th 2021 Member

Looks good :+1:

This Pull Request was closed on July 5th 2021
Powered by GitHub Issue Mirror