@tsteur opened this Pull Request on June 30th 2021 Member

Description:

Fixes two issues for sparklines visualisation when no row is found. Seems so far we did not have this use case in core:

First error:

  • Call to a member function getComparisons() on bool in plugins/CoreVisualizations/Visualizations/Sparklines.php line 125
  • Call to a member function getColumn() on bool in plugins/CoreVisualizations/Visualizations/Sparklines.php line 275

Before:
image

After:
image

You can reproduce this for example using such a URL:

  • /index.php?forceView=1&viewDataTable=sparklines&module=ExampleUI&action=getTemperaturesEvolution&label=example32323.matomo.org&idSite=1&period=month&date=2021-06-17&segment=&showtitle=1&random=7773&widget=1

image

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on June 30th 2021
Powered by GitHub Issue Mirror