Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make anchor links on Admin General Settings page work #17727

Merged
merged 1 commit into from Jun 30, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 29, 2021

Description:

Currently, links with anchors mostly don't work when linking to a different URL. That's because often the page is loaded async and it's unknown to the system when it's fully loaded. Therefore it is impossible to for example deep link to a specific system setting like https://mydomain/index.php?module=CoreAdminHome&action=generalSettings&editsiteid=5&period=day&date=yesterday&idSite=1#/HeatmapSessionRecording

This logic would make it work to make use of anchor links on the general settings page. There might be a generic solution to it but it's very tricky because the system can never really know whether it should/needs to wait for more requests to finish or whether some more might be coming etc. In many cases using again the globalAjaxQueue could work though instead as soon as there are 0 requests active after the load event then trigger this method. Such a solution may be quite tricky though as might then need to factor in whether user maybe already started scrolling etc. Could create a new issue to fix this properly maybe?

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Jun 29, 2021
@tsteur tsteur added this to the 4.4.0 milestone Jun 29, 2021
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't think there's a proper solution w/o modifying angularjs or watching the dom. As long as it provides value I think it's fine to make sure it's done explicitly.

@tsteur tsteur merged commit 75568c7 into 4.x-dev Jun 30, 2021
@tsteur tsteur deleted the anchorlinksettings branch June 30, 2021 00:26
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants