Make anchor links on Admin General Settings page work #17727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, links with anchors mostly don't work when linking to a different URL. That's because often the page is loaded async and it's unknown to the system when it's fully loaded. Therefore it is impossible to for example deep link to a specific system setting like https://mydomain/index.php?module=CoreAdminHome&action=generalSettings&editsiteid=5&period=day&date=yesterday&idSite=1#/HeatmapSessionRecording
This logic would make it work to make use of anchor links on the general settings page. There might be a generic solution to it but it's very tricky because the system can never really know whether it should/needs to wait for more requests to finish or whether some more might be coming etc. In many cases using again the
globalAjaxQueue
could work though instead as soon as there are 0 requests active after the load event then trigger this method. Such a solution may be quite tricky though as might then need to factor in whether user maybe already started scrolling etc. Could create a new issue to fix this properly maybe?Review