Add possiblity to open sites manager and directly edit a specific site using URL parameter #17726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e using URL parameter
|
Works for me locally. I'm wondering if we should remove the |
|
good point @diosmosis 👍 changed it and also refactored slightly to have less duplicated code. To be able to change the URL I had to move the id from a search query parameter to a hash so I can remove it without reloading the page. When saving or canceling then I remove the hash but not removing the search query as it's tricky to do and not really needed for now as this link will be used extremely rare. People can in worst case always click on left menu again to get all sites I reckon. |
diosmosis
reviewed
Jul 1, 2021
plugins/SitesManager/angularjs/sites-manager/sites-manager-type-model.js
Show resolved
Hide resolved
mattab
added
the
c: Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Needed for some plugin. Adding
&editsiteid=\d+should open the specified site directly. There may be edge cases where multiple sites match a searched number maybe but that be edge case as it likely would be only an issue if > 10 sites matched the specified number. Basically, the URL parameter triggers a search for that number / idsite and the site will be opened directly.Review