Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multisite links to reports now pass token_auth #17725

Merged
merged 1 commit into from Jun 30, 2021
Merged

Multisite links to reports now pass token_auth #17725

merged 1 commit into from Jun 30, 2021

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Fixes #17001

Pass token_auth parameter so embedded widget links log user in to their matomo dashboard when they click to view full reports.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 29, 2021
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 29, 2021
@justinvelluppillai justinvelluppillai marked this pull request as ready for review June 29, 2021 22:26
@diosmosis
Copy link
Member

Tested locally, everything works 👍

@diosmosis diosmosis merged commit 9d1e5b5 into 4.x-dev Jun 30, 2021
@diosmosis diosmosis deleted the 17001-multisite-deeplinks branch June 30, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

When embedding a widget with the "Multisites" report (All websites), the links are not working
2 participants
@justinvelluppillai @diosmosis